04-12-2022, 12:47 AM
Hi!
Quite well. I would simplify it in two places:
1. Having layer width or height to 0 si not illegal, it just means the layer hasn't been yet setup. It should be returned as is, without setting an error value.
2. Wouldn't check layer visibilityto set the value of "ok" member. A getter shouldn't modify the internal state of an object, it should return just the queried property.
Regards,
Quite well. I would simplify it in two places:
1. Having layer width or height to 0 si not illegal, it just means the layer hasn't been yet setup. It should be returned as is, without setting an error value.
2. Wouldn't check layer visibilityto set the value of "ok" member. A getter shouldn't modify the internal state of an object, it should return just the queried property.
Regards,